Update nest to only include the image attachment payload for cameras that support fetching media #124590
Conversation
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: nest
small-pr
|
I think the PR # has a typo in the opening text. |
Thanks, fixed, should have been 124554 |
| if not ( | ||
| device_manager := self._hass.data[DOMAIN] | ||
| .get(self._config_entry_id, {}) | ||
| .get(DATA_DEVICE_MANAGER) | ||
| ) or not (device := device_manager.devices.get(device_id)): | ||
| return False | ||
| return TraitType.CAMERA_CLIP_PREVIEW in device.traits | ||
| return [] |
There was a problem hiding this comment.
This is complex to test because it involves a race, and is a bit theoretical. This can happen when there is a race on initialization where a pubsub message is received before the device manager has been registered.
The subscriber is started first and registers this callback. Then the device manager is initialized and registered. it happens in this order because otherwise there is a race where the device manager will fetch initial state, then a message is published which isn't received, and we are missing state. Therefore we first subscribe and then fetch initial state.
Adding coverage for this could involve patching and making the device manager block, then sending messages and verifying they are received -- but the integration wouldn't have finished setup by then so its kind of odd.
If you have suggestions for a different approach i am open to it.
|
Should this be tagged for the next release? |
|
Yeah good call, i didn't realize this didn't make it in. |
Proposed change
Follow up to #124554 to only include the "image" attachment based on device properties. When updating the documentation I remembered that not all devices support attachments and now this will be more clear since we can omit the image attachment from the device trigger payload.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: