-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add touchlinesl integration #124557
Add touchlinesl integration #124557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There already is an integration for touchline, what's the difference? |
Touchline SL is essentially a completely different product - the original Touchline module speaks to the old controller over the LAN, whereas Touchline SL is controlled through an internet facing public API and has more features - the two are unfortunately not compatible 🙂 |
Check. If it's ready for review, please mark it so |
Done - I was just waiting until I'd got the docs and brands PRs together, which are now at: |
@joostlek I think I've addressed all of your feedback, thanks for the tips! I've made changes in two separate commits - let me know if you'd like me to squash down into a single commit again - I wanted to leave them separate so it was easy to see the changes I was making in response to our conversation. |
You can just leave your commits like that, in the end we squash them and merge them in one go. Squashing and force pushing only messes up the GitHub diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your future plans with the integration? Do you want to add more platforms? Based on that I might actually want to recommend using a coordinator. Using a coordinator centralizes the polling mechanism to a single component and it could help you clean up the updating part
Oh and also please checkout |
@joostlek I think I've addressed all bar one piece of feedback 🙂 |
I'll have another pass after I've done my groceries. Feel free to send me a message on discord :) |
Do you have a link to the one piece? (That saves me going through everything, and you already know which one :) ) |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing a test where we add a config entry with the same unique_id and test we abort if we set up again
Breaking change
This PR introduces a new integration for the Roth Touchline SL underfloor heating system.
It supports reading temperature, humidity and preset, based on the pytouchlinesl library which I published earlier this week.
The system supports a constant target temperature per zone, and also has a number of "global schedules". In this integration, the "Presets" for the climate zone represent the configured global schedules.
See below some screenshots of the integration when connected to my TouchlineSL module:
Documentation PR to follow for the integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: