Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bang olufsen test typing and parameter order #124419

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Improve Bang olufsen test typing and parameter order #124419

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b1a4d2
Add proper media_player typing to tests
mj23000 Aug 21, 2024
d2209d7
Add proper typing to init tests
mj23000 Aug 21, 2024
cf48298
Add proper typing to config_flow tests
mj23000 Aug 21, 2024
e0a35d3
Fix order of parameters of tests
mj23000 Aug 21, 2024
306ddf5
Add more typing
mj23000 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix order of parameters of tests
  • Loading branch information
@mj23000
mj23000 committed Aug 21, 2024
commit e0a35d300fa4019317e9154162c527e297c47b5b
26 changes: 13 additions & 13 deletions tests/components/bang_olufsen/test_media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,14 @@ async def test_async_update_playback_state(
],
)
async def test_async_update_source_change(
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
reported_source: Source,
real_source: Source,
content_type: MediaType,
progress: int,
metadata: PlaybackContentMetadata,
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
) -> None:
"""Test _async_update_source_change."""

Expand Down Expand Up @@ -465,11 +465,11 @@ async def test_async_mute_volume(
],
)
async def test_async_media_play_pause(
initial_state: RenderingState,
command: str,
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
initial_state: RenderingState,
command: str,
) -> None:
"""Test async_media_play_pause."""

Expand Down Expand Up @@ -557,12 +557,12 @@ async def test_async_media_next_track(
],
)
async def test_async_media_seek(
source: Source,
expected_result: Callable,
seek_called_times: int,
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
source: Source,
expected_result: Callable,
seek_called_times: int,
) -> None:
"""Test async_media_seek."""

Expand Down Expand Up @@ -643,13 +643,13 @@ async def test_async_clear_playlist(
],
)
async def test_async_select_source(
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
source: str,
expected_result: Callable,
audio_source_call: int,
video_source_call: int,
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
) -> None:
"""Test async_select_source with an invalid source."""

Expand Down Expand Up @@ -1086,12 +1086,12 @@ async def test_async_play_media_url_m3u(
],
)
async def test_async_browse_media(
child: dict[str, str | bool | None],
present: bool,
hass: HomeAssistant,
mock_mozart_client: AsyncMock,
mock_config_entry: MockConfigEntry,
hass_ws_client: WebSocketGenerator,
child: dict[str, str | bool | None],
present: bool,
) -> None:
"""Test async_browse_media with audio and video source."""

Expand Down