-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use library fork for ViCare integration #124107
Conversation
@@ -11,5 +11,5 @@ | |||
"documentation": "https://www.home-assistant.io/integrations/vicare", | |||
"iot_class": "cloud_polling", | |||
"loggers": ["PyViCare"], | |||
"requirements": ["PyViCare==2.32.0"] | |||
"requirements": ["PyViCare-neo==0.2.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're not planning to contribute back changes to upstream you should ask GitHub to disconnect your fork from its upstream. That way it's clear to the community that it's a separate project going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to the PR of the due diligence that has been done to continue working with upstream project before labeling the project as unmaintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to the PR of the due diligence that has been done
done, I hope that is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original owner of the lib just responded and agreed to transfer the repo to a dedicated org where we can share the ownership.
Hope it's not a big deal to change back once the repo is transferred, release is setup and the bugfixes are cherry-picked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. You can link to this discussion thread in the future PR that changes back the library.
Proposed change
This changes the API library used in ViCare integration to a new one created from a fork.
Over the last ~9 months I provided several PRs to the original library. Some of them got merged, others where not, and since December last year there was no new version release. I tried to reach the maintainers via PR comment and via Discord but got no response over the last months.
Now we have some kind of urgency as there is one bug in the library and mid of September some of the datapoints in the API will be deleted and replaced with others.
CFenner/PyViCare@2.32.0...v0.2.1
Changes:
bufferCylinder
anddhwCylinder
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: