Install and start Mosquitto MQTT broker add on from MQTT config flow #124106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
has-tests
integration: mqtt
new-feature
labels
|
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jbouwh
changed the title
8 tasks
emontnemery
reviewed
Aug 20, 2024
Co-authored-by: Erik Montnemery <erik@montnemery.com>
jbouwh
commented
Aug 21, 2024
Comment on lines
69
to
74
| "data": { | ||
| "discovery": "Enable discovery" | ||
| }, | ||
| "data_description": { | ||
| "discovery": "Option to enable MQTT automatic discovery." | ||
| } |
There was a problem hiding this comment.
This data was not used
There was a problem hiding this comment.
OK, then we clean that up in a separate PR.
emontnemery
reviewed
Aug 21, 2024
Comment on lines
69
to
74
| "data": { | ||
| "discovery": "Enable discovery" | ||
| }, | ||
| "data_description": { | ||
| "discovery": "Option to enable MQTT automatic discovery." | ||
| } |
There was a problem hiding this comment.
OK, then we clean that up in a separate PR.
emontnemery
reviewed
Aug 22, 2024
emontnemery
added
the
noteworthy
|
Thanks! |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR allows to automatically install and start the MQTT broker add-on in the Config flow to set up the MQTT integration. This means that user does not need to manually install the Mosquitto addon to be able to configure the MQTT broker from discovery. Before this PR user would get a discovery notification if the add on was installed manually.
On a supervised install the user will be shown a menu to choose to install the add-on or to manually enter the connection details.
Mqtt.config.flow.with.add-on.mp4
The
hassiofixtures used can be shared and are placed intests/components/conftest.py. In followup PR's other integrations should cleanup there own implementations and use the shared version instead.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: