-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state for alarm_control_panel in Prometheus #123753
Add state for alarm_control_panel in Prometheus #123753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @knyar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a PR! Looks good overall, just a couple of small comments from me.
Also, do you think you would also be able to add a simple test? You can look at the recent test changes to find a good example, like #119805.
4be8868
to
578d5c0
Compare
I've added the requested unit tests. |
homeassistant/components/alarm_control_panel/reproduce_state.py
Outdated
Show resolved
Hide resolved
e575650
to
28bf6ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just one minor comment, otherwise lgtm.
Appreciate adding the test!
28bf6ef
to
e828274
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Hopefully one of Home Assistant maintainers will be able to merge this soon.
462c1e5
to
a33db1c
Compare
a33db1c
to
8565640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For the future, please don't amend or squash commits after review has started to make it easier for readers to track changes. Thanks! |
We missed to update the docs. Please update this list: https://www.home-assistant.io/integrations/prometheus/#supported-metrics |
Proposed change
Export
alarm_control_panel
state with Prometheus.Type of change
Additional information
This adds support for exporting
alarm_control_panel
state with Prometheus.Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: