Add support for total YouTube views #123144
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-needed
has-tests
integration: youtube
new-feature
small-pr
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
Quality Scale: No score
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
frenck
changed the title
| native_unit_of_measurement="views", | ||
| available_fn=lambda _: True, | ||
| value_fn=lambda channel: channel[ATTR_TOTAL_VIEWS], | ||
| entity_picture_fn=lambda channel: channel[ATTR_ICON], |
There was a problem hiding this comment.
Should we just do an icon here instead of the channel icon? I think it can look strange if you add more sensors that they all have the same picture.
Wdyt?
There was a problem hiding this comment.
That's true, although it doesn't bother me. Not sure if there is an appropriate icon for both of them.
There was a problem hiding this comment.
I think subscribers is fine as is, but let's add one for the views, not sure if there is a viable icon for that. Please use the icon translations to add one
There was a problem hiding this comment.
I'm wondering, what makes the views any different from the subscribers?
Done! |
|
And push it? |
|
Yes, the push got rejected because I had to rebase. All good now! |
* Add support for retrieving the total views of a channel. * Add missing tests * Re-order imports * Another run on code format * Add missing translation * Update YouTube test snapshots
Breaking change
Proposed change
Add support for retrieving the total view count of each channel that has been added.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: