-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RecursionError in Husqvarna Automower coordinator #123085
Fix RecursionError in Husqvarna Automower coordinator #123085
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@Thomas55555 You need to click the "Ready for review"-button if you're done with addressing review comments and you want the PR to be reviewed again. |
Thanks, I know. But I haven't addressed all comments. And I'm not sure I can. |
Oh, I see. |
Did you intend to push some commits? |
Yes, commit 564f4d1 👍 |
), | ||
( | ||
["start_listening"], | ||
TimeoutException, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: I'm not sure that the exceptions set here are specific to each of the methods. Both exceptions could maybe happen for both methods.
We can address that in a follow up, since it's just a test improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Breaking change
Proposed change
Instead of recursing in the same task the coordinator creates a new background task for the call to
client_listen
on retryType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: