Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RecursionError in Husqvarna Automower coordinator #123085

Merged
merged 28 commits into from
Nov 13, 2024

Conversation

Thomas55555
Copy link
Contributor

Breaking change

Proposed change

Instead of recursing in the same task the coordinator creates a new background task for the call to client_listen on retry

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 2, 2024 21:05
@Thomas55555 Thomas55555 marked this pull request as ready for review August 12, 2024 17:48
@MartinHjelmare MartinHjelmare marked this pull request as draft August 12, 2024 18:35
@emontnemery
Copy link
Contributor

@Thomas55555 You need to click the "Ready for review"-button if you're done with addressing review comments and you want the PR to be reviewed again.

@Thomas55555
Copy link
Contributor Author

Thanks, I know. But I haven't addressed all comments. And I'm not sure I can.
But I also don't want to close the PR, because the issue is fixed and only the tests are not right.

@emontnemery
Copy link
Contributor

Thanks, I know. But I haven't addressed all comments. And I'm not sure I can. But I also don't want to close the PR, because the issue is fixed and only the tests are not right.

Oh, I see.
If you need some help, feel free to contact me on Discord, my nick there is @emontnemery

@emontnemery emontnemery marked this pull request as ready for review November 11, 2024 14:04
@MartinHjelmare MartinHjelmare marked this pull request as draft November 11, 2024 14:39
@emontnemery emontnemery marked this pull request as ready for review November 11, 2024 16:14
@MartinHjelmare
Copy link
Member

Did you intend to push some commits?

@emontnemery
Copy link
Contributor

Did you intend to push some commits?

Yes, commit 564f4d1 👍

@home-assistant home-assistant bot marked this pull request as draft November 13, 2024 08:45
),
(
["start_listening"],
TimeoutException,
Copy link
Member

@MartinHjelmare MartinHjelmare Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: I'm not sure that the exceptions set here are specific to each of the methods. Both exceptions could maybe happen for both methods.

We can address that in a follow up, since it's just a test improvement.

@MartinHjelmare MartinHjelmare marked this pull request as ready for review November 13, 2024 08:51
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2024.11.2 milestone Nov 13, 2024
@MartinHjelmare MartinHjelmare merged commit 8278754 into home-assistant:dev Nov 13, 2024
34 checks passed
@Thomas55555 Thomas55555 deleted the max-recursion branch November 13, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecursionError in Husqvarna Automower coordinator
4 participants