-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uplink info to UniFi Device tracker attributes #123032
Add Uplink info to UniFi Device tracker attributes #123032
Conversation
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Awesome! In almost all cases it's now preferred to create separate sensors, I will at one point in time create sensors from the current attributes as well. |
e864a75
to
edab242
Compare
Done! This will do the job for what I'm trying to accomplish, but I just got to thinking in relation to the WAN stats PR... would it be useful to think in terms of WAN sensors? This PR is the uplink for any device, so it will be the MAC of the router for any AP, so it has possible usage outside of my usecase, but a WAN category of sensors would include things like availability percentage, is up, is uplink (currently used as uplink), IP address, and tx data (bytes, dropped, etc.). I don't know if that would make sense to think of "WANs" as a virtual "Device" or just add the sensors to the router devicethat has wan subobjects. With this PR, my workflow would look something like "Create automation that looks for the uplink MAC on my router changing to the MAC of my backup internet modem". The extended WAN approach would be something like, "Create automation that looks for "WAN2 Is Uplink is True" to determine if I'm in a failover state. |
Oh, furthermore, it looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
7e0525c
to
e27f075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is Ok! I will wait a week or so to merge as the new release is tomorrow.
You also need to make Ruff pass
e27f075
to
4660227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebase and this final comment I think that this is ready to merge
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
45d08ae
to
9d6c90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just noticed the test string is wrong, can you fix that. Ready to merge after that
9d6c90a
to
596966e
Compare
Thanks @ViViDboarder |
Proposed change
Adds attributes to UniFi Device Tracker to provide upstream information. Intended use case here is for tracking when upstream failover happens.
I'm also open to this being a dedicated sensor and limiting it to routers rather than any "UniFi device", but this was the simplest change so I figured I'd start here because similar data is already read as attributes for "UniFi clients".
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: