-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pylint broad-exception-raised rule with ruff #123021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
requested review from
a team,
pavoni,
bdraco,
chemelli74 and
mib1185
as code owners
August 1, 2024 13:15
home-assistant
bot
added
cla-signed
code-quality
core
has-tests
small-pr
PRs with less than 30 lines.
labels
Aug 1, 2024
epenet
commented
Aug 1, 2024
epenet
commented
Aug 1, 2024
@@ -59,7 +59,7 @@ def get_suggested(schema, key): | |||
return None | |||
return k.description["suggested_value"] | |||
# Wanted key absent from schema | |||
raise Exception | |||
raise KeyError(f"Key `{key}` is missing from schema") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: previously ignored because script
folder is not checked by pylint
, but it is checked by ruff
chemelli74
approved these changes
Aug 2, 2024
epenet
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Aug 2, 2024
frenck
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @epenet 👍
../Frenck
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
code-quality
core
has-tests
small-pr
PRs with less than 30 lines.
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
new https://docs.astral.sh/ruff/rules/raise-vanilla-class/
old https://pylint.pycqa.org/en/latest/user_guide/messages/warning/broad-exception-raised.html
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: