Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calories to energy sensor device class #122796

Merged
merged 18 commits into from
Sep 10, 2024

Conversation

dudanov
Copy link
Contributor

@dudanov dudanov commented Jul 29, 2024

Proposed change

Discuss of this change.
This PR is the first one that adds calories to the energy class.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dudanov dudanov marked this pull request as ready for review July 29, 2024 19:28
@dudanov dudanov requested a review from a team as a code owner July 29, 2024 19:28
@edenhaus
Copy link
Contributor

edenhaus commented Aug 2, 2024

The tests are failing. Can you please give it a look and fix it?

@edenhaus edenhaus marked this pull request as draft August 2, 2024 13:55
@dudanov
Copy link
Contributor Author

dudanov commented Aug 2, 2024

The tests are failing. Can you please give it a look and fix it?

Done! All tests passed in dev container.

@dudanov dudanov marked this pull request as ready for review August 2, 2024 16:07
@dudanov dudanov force-pushed the add-calories-units branch from 3926808 to 130d06f Compare August 2, 2024 16:09
@dudanov
Copy link
Contributor Author

dudanov commented Aug 15, 2024

mypy fails due to no fault of my own.

@dudanov dudanov force-pushed the add-calories-units branch from 130d06f to b2de5dd Compare August 15, 2024 06:17
homeassistant/util/unit_conversion.py Outdated Show resolved Hide resolved
homeassistant/util/unit_conversion.py Outdated Show resolved Hide resolved
tests/util/test_unit_conversion.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 19, 2024 12:58
@dudanov dudanov requested a review from edenhaus August 20, 2024 16:09
@dudanov dudanov marked this pull request as ready for review August 20, 2024 16:09
@dudanov
Copy link
Contributor Author

dudanov commented Aug 21, 2024

@edenhaus hi. could you please re-review? I seem to have done everything as required, local tests passed.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dudanov

@emontnemery
Copy link
Contributor

There are some test failures which I believe are unrelated. I've updated the PR branch to let the tests run again just in case though.

@emontnemery emontnemery reopened this Sep 10, 2024
@emontnemery
Copy link
Contributor

Trying again to retrigger the tests

@emontnemery
Copy link
Contributor

Test failures are related to Python package cache issue, I'm merging this PR

@emontnemery emontnemery merged commit dcd7830 into home-assistant:dev Sep 10, 2024
74 of 76 checks passed
@dudanov
Copy link
Contributor Author

dudanov commented Sep 10, 2024

Thanks, @emontnemery.
Can you please pay your attention to this last PR?

@dudanov dudanov deleted the add-calories-units branch September 10, 2024 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants