-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calories to energy sensor device class #122796
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
The tests are failing. Can you please give it a look and fix it? |
Done! All tests passed in dev container. |
3926808
to
130d06f
Compare
|
130d06f
to
b2de5dd
Compare
…o add-calories-units
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…o-core into add-calories-units
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
@edenhaus hi. could you please re-review? I seem to have done everything as required, local tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dudanov
There are some test failures which I believe are unrelated. I've updated the PR branch to let the tests run again just in case though. |
Trying again to retrigger the tests |
Test failures are related to Python package cache issue, I'm merging this PR |
Thanks, @emontnemery. |
Proposed change
Discuss of this change.
This PR is the first one that adds calories to the energy class.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: