Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less use of hass.data[DECONZ_DOMAIN] in deCONZ tests #122657

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jul 26, 2024

Breaking change

Proposed change

Be less use of hass.data[DECONZ_DOMAIN] in preparation for runtime_data
Don't directly test get_deconz_api

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

tests/components/deconz/test_init.py Outdated Show resolved Hide resolved
tests/components/deconz/test_init.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 26, 2024 16:30
@Kane610 Kane610 marked this pull request as ready for review July 26, 2024 16:52
@home-assistant home-assistant bot requested a review from joostlek July 26, 2024 16:52
@Kane610 Kane610 merged commit 58419f1 into home-assistant:dev Jul 26, 2024
26 checks passed
@Kane610 Kane610 deleted the deconz-less_use_of_hass_data_deconz_domain_in_tests branch July 26, 2024 18:58
@Kane610
Copy link
Member Author

Kane610 commented Jul 26, 2024

Thanks @joostlek

@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants