-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyvesync to 2.1.12 #122318
Bump pyvesync to 2.1.12 #122318
Conversation
Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant. Thanks already! 👍 |
@joostlek It is in the last line of the change request description. webdjoe/pyvesync@2.1.10...2.1.12 |
Oh, missed that, for next time maybe put it in proposed changes so there's no confusion about it :) |
Will do! Thanks for the feedback. |
I don't see why bumping pyvesync would make these tests fail. I suspect they were broken previously. |
They were not broken. The vesync bump changes something in the data structure which is reflected in the diagnostics tests |
Breaking change
Proposed change
Link to changes in this update: webdjoe/pyvesync@2.1.10...2.1.12
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: