Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyvesync to 2.1.12 #122318

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Bump pyvesync to 2.1.12 #122318

merged 5 commits into from
Jul 22, 2024

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented Jul 21, 2024

Breaking change

Proposed change

Link to changes in this update: webdjoe/pyvesync@2.1.10...2.1.12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • [] Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdnninja cdnninja marked this pull request as ready for review July 21, 2024 15:46
@joostlek
Copy link
Member

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@joostlek joostlek changed the title bump pyvesync Bump pyvesync to 2.1.12 Jul 21, 2024
@cdnninja
Copy link
Contributor Author

@joostlek It is in the last line of the change request description. webdjoe/pyvesync@2.1.10...2.1.12

@joostlek
Copy link
Member

Oh, missed that, for next time maybe put it in proposed changes so there's no confusion about it :)

@cdnninja
Copy link
Contributor Author

Will do! Thanks for the feedback.

@cdnninja
Copy link
Contributor Author

I don't see why bumping pyvesync would make these tests fail. I suspect they were broken previously.

@joostlek
Copy link
Member

They were not broken. The vesync bump changes something in the data structure which is reflected in the diagnostics tests

@frenck frenck merged commit ea94cdb into home-assistant:dev Jul 22, 2024
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
@cdnninja cdnninja deleted the patch-2 branch January 1, 2025 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants