Skip to content

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 20, 2024

Note that this PR is merging to yale_august_split

There are no code changes from august other than renames.

Proposed change

Yale and August have split into two separate companies and the APIs are diverging enough that the integration needs to be split into two.

Plan:

  1. Copy the august integration to yale and change all the names. (this PR - Split august and yale integrations [part 1] #122253)
  2. Replace config flow with Oauth (uses account link)
  3. Replace pubnub push with the new websocket from Yale Global
  4. Merge back to dev
  5. Deprecate the old yale api calls from august

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco bdraco changed the title Split august and yale intregrations Split august and yale integrations Jul 20, 2024
@bdraco bdraco dismissed home-assistant[bot]’s stale review July 20, 2024 13:39

This is a copy, platforms are already reviewed

bdraco added a commit to home-assistant/home-assistant.io that referenced this pull request Jul 20, 2024
This PR should not merge until the integration branch
in home-assistant/core#122253 is complete
@bdraco bdraco marked this pull request as ready for review July 20, 2024 14:01
@bdraco bdraco changed the title Split august and yale integrations Split august and yale integrations [part 1] Jul 20, 2024
@@ -0,0 +1,81 @@
{
"status_timestamp": 1512811834532,
"appID": "august-iphone",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some use of "august" in the test fixtures.

Copy link
Member Author

@bdraco bdraco Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected as the yale (company) code was forked from the original august code and they still have august all over the place internally. Even the yale locks you buy have august in the bluetooth firmware (although there are no references on the packaging or device)

Copy link
Member Author

@bdraco bdraco Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its all super confusing. I'll try to summarize what I know but even some of this is based on discovery and patchwork information as even the people working at entities themselves don't seem to have the full story.

August was sold to ASSA ABLOY, and than the North American devices were spun off into yet another company "Yale August" aka august.

  • The original august system is "dead".
  • The yale integration will be for what the "ASSA ABLOY" company is doing. aka yale fork aka outside of North America. "ASSA ABLOY" is moving most/all of their existing integrations to this platform. Yale Doorman and other similar devices will only eventually be supported here. Push updates are currently broken here because the api is now websocket based.
  • The august integration will be for what the "Yale August" company is doing. aka august fork aka North America. Assure2 locks and the Assume+ locks will only be supported here. The original August company devices are folding into Yale August. The august company is keeping the current pubnub based system for integrations at this time. They may move to another system but thats unknown at this point.

@MartinHjelmare MartinHjelmare marked this pull request as draft July 29, 2024 16:27
@bdraco bdraco marked this pull request as ready for review July 29, 2024 20:01
@balloob balloob merged commit 336e37e into yale_august_split Jul 31, 2024
40 checks passed
@balloob balloob deleted the yale branch July 31, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants