-
-
Notifications
You must be signed in to change notification settings - Fork 35k
Split august and yale integrations [part 1] #122253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy, platforms are already reviewed
This PR should not merge until the integration branch in home-assistant/core#122253 is complete
@@ -0,0 +1,81 @@ | |||
{ | |||
"status_timestamp": 1512811834532, | |||
"appID": "august-iphone", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still some use of "august" in the test fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected as the yale (company) code was forked from the original august code and they still have august all over the place internally. Even the yale locks you buy have august in the bluetooth firmware (although there are no references on the packaging or device)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its all super confusing. I'll try to summarize what I know but even some of this is based on discovery and patchwork information as even the people working at entities themselves don't seem to have the full story.
August was sold to ASSA ABLOY, and than the North American devices were spun off into yet another company "Yale August" aka august
.
- The original august system is "dead".
- The
yale
integration will be for what the "ASSA ABLOY" company is doing. aka yale fork aka outside of North America. "ASSA ABLOY" is moving most/all of their existing integrations to this platform. Yale Doorman and other similar devices will only eventually be supported here. Push updates are currently broken here because the api is now websocket based. - The
august
integration will be for what the "Yale August" company is doing. aka august fork aka North America. Assure2 locks and the Assume+ locks will only be supported here. The original August company devices are folding intoYale August
. Theaugust
company is keeping the current pubnub based system for integrations at this time. They may move to another system but thats unknown at this point.
Note that this PR is merging to
yale_august_split
There are no code changes from
august
other than renames.Proposed change
Yale and August have split into two separate companies and the APIs are diverging enough that the integration needs to be split into two.
Plan:
august
integration toyale
and change all the names. (this PR - Split august and yale integrations [part 1] #122253)Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: