Fix for Environment Canada date being wrong after midnight

[gwww]

Proposed change

Fix for Environment Canada date being wrong after midnight. The data from Environment Canada includes the previous night's forecast on the following day. This fix takes that into account.

michaeldavie/env_canada@v0.7.1...v0.7.2

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #Environment Canada weather day labels are wrong at after midnight #118622
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @michaeldavie, mind taking a look at this pull request as it has been labeled with an integration (environment_canada) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of environment_canada can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign environment_canada Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[gwww]

I put this back to draft.

The approach used is not bad for presenting the forecast properly, but I may have a better way. Still exploring so the code as is may be the best we can do.

I'm thinking exacty what you wrote about timezones. I have a change I'm testing in the env_canada lib.

Thank you so much for your help!

[gwww]

I'm testing live now. Much cleaner now! Even better, pushed some of the logic into the env_canada lib for better separation of concerns.

[gjohansson-ST]

Does the timestamp in the lib contain a timezone so it's accurately calculating to UTC?

[gwww]

Yes. It is UTC.

[gwww]

I’m running this live in two time zones to make sure everything works as expected. I’m sure from the tests that it does what I want. Checking that I want the right thing 😂

[gwww]

I ran this overnight and everything works great! I had two weather reports active, one for the east coast and another for the west coast (a 3 hour time zone difference). Everything updated just as expected and the reported bug no longer exists.

Thank you @gjohansson-ST for all your help! Very appreciated!

[gjohansson-ST]

Thanks @gwww 👍