Setup Google Cloud from the UI #121502
Merged
Setup Google Cloud from the UI #121502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
config-flow
|
Hey there @lufton, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
tronikos
changed the title
19 tasks
arturpragacz
suggested changes
Aug 31, 2024
joostlek
requested changes
Sep 2, 2024
Comment on lines
53
to
102
| async def test_user_flow_missing_file(hass: HomeAssistant) -> None: | ||
| """Test user flow when uploaded file is missing.""" | ||
| result = await hass.config_entries.flow.async_init( | ||
| DOMAIN, context={"source": config_entries.SOURCE_USER} | ||
| ) | ||
| assert result["type"] is FlowResultType.FORM | ||
| assert result["errors"] == {} | ||
|
|
||
| with patch( | ||
| "homeassistant.components.google_cloud.async_setup_entry", | ||
| return_value=True, | ||
| ) as mock_setup_entry: | ||
| result = await hass.config_entries.flow.async_configure( | ||
| result["flow_id"], | ||
| {UPLOADED_KEY_FILE: str(uuid4())}, | ||
| ) | ||
| await hass.async_block_till_done() | ||
|
|
||
| assert result["type"] is FlowResultType.FORM | ||
| assert result["errors"] == {"base": "invalid_file"} | ||
| assert len(mock_setup_entry.mock_calls) == 0 | ||
|
|
||
|
|
||
| async def test_user_flow_invalid_file( | ||
| hass: HomeAssistant, | ||
| create_invalid_google_credentials_json: str, | ||
| mock_process_uploaded_file: MagicMock, | ||
| ) -> None: | ||
| """Test user flow when uploaded file is invalid.""" | ||
| result = await hass.config_entries.flow.async_init( | ||
| DOMAIN, context={"source": config_entries.SOURCE_USER} | ||
| ) | ||
| assert result["type"] is FlowResultType.FORM | ||
| assert result["errors"] == {} | ||
|
|
||
| uploaded_file = str(uuid4()) | ||
| with patch( | ||
| "homeassistant.components.google_cloud.async_setup_entry", | ||
| return_value=True, | ||
| ) as mock_setup_entry: | ||
| result = await hass.config_entries.flow.async_configure( | ||
| result["flow_id"], | ||
| {UPLOADED_KEY_FILE: uploaded_file}, | ||
| ) | ||
| await hass.async_block_till_done() | ||
|
|
||
| assert result["type"] is FlowResultType.FORM | ||
| assert result["errors"] == {"base": "invalid_file"} | ||
| mock_process_uploaded_file.assert_called_with(hass, uploaded_file) | ||
| assert len(mock_setup_entry.mock_calls) == 0 |
There was a problem hiding this comment.
We should make sure the tests end in either an abort or create entry to test the flow is able to recover
There was a problem hiding this comment.
On errors I don't abort but rather show the form with the error without moving to the next step:
Since this is the very first form and there is no state I don't think it's worth complicating the test setup and continuing the flow which will essentially retest test_user_flow_success
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Sep 2, 2024
arturpragacz
approved these changes
Sep 2, 2024
|
Thanks for the review! |
|
If it helps, while the context of this review is still fresh in your mind, I also have #120854 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Google Cloud can now be setup from the UI
tts.google_cloud_sayservice and avoid a breaking change.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: