Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery for Z-Wave Meter Reset #119968

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

AlCalzone
Copy link
Contributor

@AlCalzone AlCalzone commented Jun 19, 2024

Breaking change

Proposed change

Adds this entity:
grafik

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title add discovery for Z-Wave Meter Reset Add discovery for Z-Wave Meter Reset Jun 19, 2024
@AlCalzone AlCalzone marked this pull request as ready for review June 20, 2024 09:33
@AlCalzone AlCalzone requested a review from a team as a code owner June 20, 2024 09:33
@AlCalzone AlCalzone marked this pull request as draft June 20, 2024 09:33
@AlCalzone
Copy link
Contributor Author

Leaving as draft until the linked PR is merged

@raman325
Copy link
Contributor

this PR is dependent on #120047

@AlCalzone AlCalzone marked this pull request as ready for review June 21, 2024 08:07
@marcelveldt
Copy link
Member

CI error on codecov can be ignored, generic issue.

@marcelveldt marcelveldt merged commit a1884ed into home-assistant:dev Jun 21, 2024
20 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
property={RESET_METER_PROPERTY},
type={ValueType.BOOLEAN},
),
entity_category=EntityCategory.DIAGNOSTIC,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be EntityCategory.CONFIG since it's an entity that allows changing something about the feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe the notification idle buttons should be changed too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good. 👍

@home-assistant home-assistant unlocked this conversation Sep 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button entity to reset Meter CC
4 participants