Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FAN_ONLY mode to ccm15 #118804

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add missing FAN_ONLY mode to ccm15 #118804

merged 2 commits into from
Jun 4, 2024

Conversation

arturyak
Copy link
Contributor

@arturyak arturyak commented Jun 4, 2024

Added missed FAN_ONLY mode

Breaking change

None

Proposed change

Added missed FAN_ONLY mode
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Added missed FAN_ONLY mode
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arturyak

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jun 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 4, 2024 13:17
@home-assistant
Copy link

home-assistant bot commented Jun 4, 2024

Hey there @ocalvo, mind taking a look at this pull request as it has been labeled with an integration (ccm15) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ccm15 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ccm15 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@arturyak arturyak marked this pull request as ready for review June 4, 2024 13:22
@home-assistant home-assistant bot dismissed their stale review June 4, 2024 13:22

Stale

@epenet epenet changed the title Update climate.py Added missing FAN_ONLY mode to ccm15 Jun 4, 2024
@epenet epenet changed the title Added missing FAN_ONLY mode to ccm15 Add missing FAN_ONLY mode to ccm15 Jun 4, 2024
@epenet epenet added this to the 2024.6.0 milestone Jun 4, 2024
epenet
epenet previously requested changes Jun 4, 2024
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust tests accordingly

@home-assistant home-assistant bot marked this pull request as draft June 4, 2024 13:52
@arturyak arturyak marked this pull request as ready for review June 4, 2024 18:35
@home-assistant home-assistant bot requested a review from epenet June 4, 2024 18:35
@arturyak
Copy link
Contributor Author

arturyak commented Jun 4, 2024

Please adjust tests accordingly

Done. I am a newbie here. Sorry for the inconvenience.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arturyak 👍

../Frenck

@frenck frenck dismissed epenet’s stale review June 4, 2024 18:58

Comment addressed

@frenck frenck merged commit 513262c into home-assistant:dev Jun 4, 2024
24 checks passed
frenck pushed a commit that referenced this pull request Jun 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mode Fan only is missing for Midea CCM15 integration
4 participants