Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum setpoint deadband to Climate entity #118186

Closed
wants to merge 10 commits into from
Closed

Add minimum setpoint deadband to Climate entity #118186

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11885b6
Add minimum setpoint deadband to Climate entity
gjohansson-ST May 26, 2024
4d7282f
Fixes
gjohansson-ST May 26, 2024
0c1f23f
Change min_temp_range to not set
gjohansson-ST May 30, 2024
b1056b6
Validate range to max/min
gjohansson-ST May 30, 2024
dd177e1
min_temperature_range None by default
gjohansson-ST Aug 12, 2024
719ccc1
Fixes
gjohansson-ST Aug 14, 2024
df18430
More fixes
gjohansson-ST Aug 14, 2024
5b5f0b5
Reset temp unit
gjohansson-ST Aug 14, 2024
95d837e
Fixes
gjohansson-ST Aug 23, 2024
cba8da1
Add to demo
gjohansson-ST Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change min_temp_range to not set
  • Loading branch information
@gjohansson-ST
gjohansson-ST committed Aug 23, 2024
commit 0c1f23ffc8b216b35e06f3f99f9aa942e43a3238
6 changes: 3 additions & 3 deletions homeassistant/components/climate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ class ClimateEntity(Entity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
_attr_target_humidity: float | None = None
_attr_target_temperature_high: float | None
_attr_target_temperature_low: float | None
_attr_min_temperature_range: float | None = None
_attr_min_temperature_range: float | None
_attr_target_temperature_step: float | None = None
_attr_target_temperature: float | None = None
_attr_temperature_unit: str
Expand Down Expand Up @@ -524,7 +524,6 @@ def state_attributes(self) -> dict[str, Any]:
supported_features = self.supported_features
temperature_unit = self.temperature_unit
precision = self.precision
min_temp_range = self.min_temperature_range
hass = self.hass

data: dict[str, str | float | None] = {
Expand All @@ -548,7 +547,8 @@ def state_attributes(self) -> dict[str, Any]:
data[ATTR_TARGET_TEMP_LOW] = show_temp(
hass, self.target_temperature_low, temperature_unit, precision
)
data[ATTR_MIN_TEMP_RANGE] = min_temp_range
if hasattr(self, "min_temperature_range"):
data[ATTR_MIN_TEMP_RANGE] = self.min_temperature_range

if (current_humidity := self.current_humidity) is not None:
data[ATTR_CURRENT_HUMIDITY] = current_humidity
Expand Down