-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Matter startup when Matter bridge is present #116569
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
codecov can be ignored because this is a patch for a temporary patch |
Why should we not add tests? Things can still go wrong even if it's temporary. |
Because the actual temporary patch doesn't have a test either. This is temporary code we want to rip out asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge and move forward atm, as I want to ship the patch release and not leave this known issue in.
../Frenck
Proposed change
Fix small oversight in the patch for transitions. In case of a bridged device the deviceinfo is different.
Fixes a crashing set-up of Matter in 2024.5 release reported on discord and forum.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: