-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ovoenergy to 2.0.0 #115921
Update ovoenergy to 2.0.0 #115921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, although not sure if my review means anything, as I am not a code owner 😄
if custom_account := entry.data.get(CONF_ACCOUNT) is not None: | ||
client.custom_account_id = custom_account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move code outside of the try block that is not expected to raise aiohttp.ClientError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timmo001
Breaking change
Proposed change
Updates and fixes ovoenergy integration.
https://github.com/timmo001/ovoenergy/releases/tag/2.0.0
timmo001/ovoenergy@v1.2.0...2.0.0
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: