Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lyric: Properly tie room accessories to the data coordinator #115902

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Lyric: Properly tie room accessories to the data coordinator #115902

merged 8 commits into from
Aug 2, 2024

Conversation

dalinicus
Copy link

@dalinicus dalinicus commented Apr 20, 2024 •
edited
Loading

Proposed change

Properly tie lyric accessories to the data coordinator so that it properly receives updates to sensor values. Currently it holds onto the initial values provided during sensor setup and never reaches back out to the coordinator for new values.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: n/a; noticed locally when developing additional features for this integration
  • Link to documentation pull request: n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (lyric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lyric can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lyric Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dalinicus dalinicus changed the title Properly tie lyric accessories to the data coordinator Lyric: Properly tie room accessories to the data coordinator May 5, 2024
@edenhaus
Copy link
Contributor

edenhaus commented Jul 8, 2024

It would be nice to add a test for this fix so we can make sure it never happens again

emontnemery
emontnemery approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalinicus 👍

@emontnemery emontnemery added this to the 2024.8.0 milestone Aug 2, 2024
@emontnemery
Copy link
Contributor

It would be nice to add a test for this fix so we can make sure it never happens again

Yeah, that would be nice, but the integration has no tests so we shouldn't require that for this bugfix to be merged.

@emontnemery emontnemery merged commit db238a7 into home-assistant:dev Aug 2, 2024
25 of 26 checks passed
frenck pushed a commit that referenced this pull request Aug 2, 2024
@frenck
Lyric: Properly tie room accessories to the data coordinator (#115902)
2520fcd 
* properly tie lyric accessories to the data coordinator so sensors recieve updates

* only check for accessories for LCC devices

* revert: meant to give it its own branch and PR
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
@dalinicus dalinicus deleted the bugfix/lyric-accessories-not-updating branch August 3, 2024 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timmo001 timmo001 timmo001 left review comments

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed integration: lyric Quality Scale: silver small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dalinicus @edenhaus @emontnemery @timmo001 @frenck