Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set follow_imports to normal [mypy] #115521

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 13, 2024

Proposed change

follow_imports = normal is recommended as default. silent only if normal causes issues which aren't easily fixed.
https://mypy.readthedocs.io/en/stable/running_mypy.html#follow-imports

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner April 13, 2024 09:43
@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Apr 13, 2024
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Apr 13, 2024
Copy link
Contributor

@albertomontesg albertomontesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an estimation on how this change would impact MyPy output on the codebase. I would expect that now telling MyPy to follow imports to yield a bunch of warnings or errors during the type checking process.

@cdce8p
Copy link
Member Author

cdce8p commented Apr 14, 2024

Do you have an estimation on how this change would impact MyPy output on the codebase. I would expect that now telling MyPy to follow imports to yield a bunch of warnings or errors during the type checking process.

The mypy output does not change. If there had been issues in the past, those were already fixed.

@cdce8p cdce8p merged commit 6422bc4 into home-assistant:dev Apr 14, 2024
38 checks passed
@cdce8p cdce8p deleted the follow_imports branch April 14, 2024 22:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants