Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump emulated-roku to 0.3.0 to fix Sofabaton Support #115452

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

shawnweeks
Copy link
Contributor

@shawnweeks shawnweeks commented Apr 12, 2024

Proposed change

Update emulated-roku to 0.3.0 to support Sofabaton. The upstream library made a slight tweak to the http headers allowing newer versions of the Sofabaton app to detect it.

See martonperei/emulated_roku@0.2.1...0.3.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. See martonperei/emulated_roku@09422fa
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shawnweeks

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 12, 2024 05:19
@shawnweeks shawnweeks marked this pull request as ready for review April 12, 2024 05:22
@shawnweeks shawnweeks force-pushed the update_emulated_roku branch 5 times, most recently from b18ac58 to 58be07c Compare April 13, 2024 03:50
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 👍

@home-assistant home-assistant bot marked this pull request as draft April 13, 2024 05:12
@shawnweeks
Copy link
Contributor Author

@shawnweeks shawnweeks force-pushed the update_emulated_roku branch from 58be07c to ff558f9 Compare April 13, 2024 06:06
@shawnweeks shawnweeks marked this pull request as ready for review April 13, 2024 06:06
@home-assistant home-assistant bot requested a review from bdraco April 13, 2024 06:06
@bdraco
Copy link
Member

bdraco commented Apr 13, 2024

@bdraco see martonperei/emulated_roku@09422fa

There is more than a single commit in this release. Please include the full changeset in the opening text:

Example:

https://github.com/martonperei/emulated_roku/releases/tag/0.3.0

martonperei/emulated_roku@0.2.1...0.3.0 (preferred)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shawnweeks

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 13, 2024
@shawnweeks shawnweeks force-pushed the update_emulated_roku branch from ff558f9 to 247e335 Compare April 13, 2024 08:19
@shawnweeks shawnweeks force-pushed the update_emulated_roku branch from 247e335 to 9effd02 Compare April 15, 2024 00:52
@bdraco bdraco merged commit b1bd9dc into home-assistant:dev Apr 15, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed dependency integration: emulated_roku Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants