Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config_flow to bluesound integration #115207

Merged
merged 21 commits into from
Jul 28, 2024
Merged

Add config_flow to bluesound integration #115207

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5bdbadb
Add config flow to bluesound
LouisChrist Apr 5, 2024
43c2049
update init
LouisChrist Jul 23, 2024
3a70405
abort flow if connection is not possible
LouisChrist Jul 23, 2024
e647993
add to codeowners
LouisChrist Jul 23, 2024
41f8963
update unique id
LouisChrist Jul 23, 2024
6e53e6c
add async_unload_entry
LouisChrist Jul 23, 2024
3b9e4c9
add import flow
LouisChrist Jul 23, 2024
780bf37
add device_info
LouisChrist Jul 23, 2024
86ee5d7
add zeroconf
LouisChrist Jul 23, 2024
8cadb9e
fix errors
LouisChrist Jul 25, 2024
e27dc69
formatting
LouisChrist Jul 25, 2024
f39e6e9
use bluos specific zeroconf service type
LouisChrist Jul 25, 2024
45bbadf
implement requested changes
LouisChrist Jul 26, 2024
36ac906
implement requested changes
LouisChrist Jul 27, 2024
a5b1fa4
fix test; add more tests
LouisChrist Jul 27, 2024
4027452
use AsyncMock assert functions
LouisChrist Jul 27, 2024
6343225
fix potential naming collision
LouisChrist Jul 27, 2024
80a9112
move setup_services back to media_player.py
LouisChrist Jul 27, 2024
d64713a
implement requested changes
LouisChrist Jul 27, 2024
63bb483
add port to zeroconf flow
LouisChrist Jul 27, 2024
e35199b
Fix comments
joostlek Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use AsyncMock assert functions
  • Loading branch information
@LouisChrist
LouisChrist committed Jul 27, 2024
commit 40274520a315ecde84cceb0241dcd680a6b3b809
25 changes: 13 additions & 12 deletions tests/components/bluesound/test_config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ async def test_user_flow_success(
assert result["type"] is FlowResultType.CREATE_ENTRY
assert result["title"] == "player-name"
assert result["data"] == {CONF_HOST: "1.1.1.1", CONF_PORT: 11000}
assert len(mock_setup_entry.mock_calls) == 1
assert len(mock_player_sync_status.mock_calls) == 1

mock_setup_entry.assert_called_once()
mock_player_sync_status.assert_called_once()


async def test_user_flow_cannot_connect(
Expand Down Expand Up @@ -71,7 +72,7 @@ async def test_user_flow_cannot_connect(
}
)

assert len(mock_player_sync_status_client_connection_error.mock_calls) == 1
mock_player_sync_status_client_connection_error.assert_called_once()


async def test_user_flow_aleady_configured(
Expand Down Expand Up @@ -103,7 +104,7 @@ async def test_user_flow_aleady_configured(
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "already_configured"

assert len(mock_player_sync_status.mock_calls) == 1
mock_player_sync_status.assert_called_once()


async def test_import_flow_success(
Expand All @@ -122,8 +123,8 @@ async def test_import_flow_success(
assert result["title"] == "player-name"
assert result["data"] == {CONF_HOST: "1.1.1.1", CONF_PORT: 11000}

assert len(mock_setup_entry.mock_calls) == 1
assert len(mock_player_sync_status.mock_calls) == 1
mock_setup_entry.assert_called_once()
mock_player_sync_status.assert_called_once()


async def test_import_flow_cannot_connect(
Expand All @@ -139,7 +140,7 @@ async def test_import_flow_cannot_connect(
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "cannot_connect"

assert len(mock_player_sync_status_client_connection_error.mock_calls) == 1
mock_player_sync_status_client_connection_error.assert_called_once()


async def test_import_flow_already_configured(
Expand All @@ -165,7 +166,7 @@ async def test_import_flow_already_configured(
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "already_configured"

assert len(mock_player_sync_status.mock_calls) == 1
mock_player_sync_status.assert_called_once()


async def test_zeroconf_flow_success(
Expand All @@ -189,8 +190,8 @@ async def test_zeroconf_flow_success(
assert result["type"] is FlowResultType.FORM
assert result["step_id"] == "confirm"

assert len(mock_setup_entry.mock_calls) == 0
assert len(mock_player_sync_status.mock_calls) == 1
mock_setup_entry.assert_not_called()
mock_player_sync_status.assert_called_once()


async def test_zeroconf_flow_cannot_connect(
Expand All @@ -214,7 +215,7 @@ async def test_zeroconf_flow_cannot_connect(
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "cannot_connect"

assert len(mock_player_sync_status_client_connection_error.mock_calls) == 1
mock_player_sync_status_client_connection_error.assert_called_once()


async def test_zeroconf_flow_already_configured(
Expand Down Expand Up @@ -250,4 +251,4 @@ async def test_zeroconf_flow_already_configured(

assert mock_entry.data[CONF_HOST] == "1.1.1.1"

assert len(mock_player_sync_status.mock_calls) == 1
mock_player_sync_status.assert_called_once()