Skip to content

Conversation

natekspencer
Copy link
Contributor

@natekspencer natekspencer commented Apr 5, 2024

Breaking change

Proposed change

Fixes an issue where cat detected status is missed on Litter-Robot 4
natekspencer/pylitterbot@v2023.4.9...v2023.4.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 5, 2024

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (litterrobot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of litterrobot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign litterrobot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck added this to the 2024.4.1 milestone Apr 5, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @natekspencer 👍

../Frenck

frenck
frenck previously requested changes Apr 5, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the CI is failing, it seems like the updated library isn't fully compatible with our code/tests?

Can you take a look?

../Frenck

@home-assistant
Copy link

home-assistant bot commented Apr 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 5, 2024 07:08
@frenck frenck modified the milestones: 2024.4.1, 2024.4.2 Apr 5, 2024
@natekspencer
Copy link
Contributor Author

natekspencer commented Apr 5, 2024

Hmm the CI is failing, it seems like the updated library isn't fully compatible with our code/tests?

Can you take a look?

../Frenck

I forgot to push my last commit before opening the PR and passing out 🤦‍♂️. This should be good now.

The new errors in CI appear unrelated to these changes.

@natekspencer natekspencer marked this pull request as ready for review April 5, 2024 15:51
@home-assistant home-assistant bot requested a review from frenck April 5, 2024 15:51
@natekspencer natekspencer marked this pull request as draft April 5, 2024 17:21
@natekspencer
Copy link
Contributor Author

natekspencer commented Apr 5, 2024

After more testing over night, it looks like I need to make one more change to the library to account for the proper transitioning of cat detect/cat sensor timing, so moving this to draft until I do that

Ready for review now

@natekspencer natekspencer changed the title Bump pylitterbot to 2023.4.10 Bump pylitterbot to 2023.4.11 Apr 5, 2024
@natekspencer natekspencer marked this pull request as ready for review April 5, 2024 19:12
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @natekspencer 👍🏻

@cdce8p cdce8p dismissed frenck’s stale review April 6, 2024 10:15

Addressed

@cdce8p cdce8p merged commit 6594d02 into home-assistant:dev Apr 6, 2024
@natekspencer natekspencer deleted the lr-dep branch April 6, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Litter-Robot states are not updated in real-time
3 participants