-
-
Notifications
You must be signed in to change notification settings - Fork 35k
Bump pylitterbot to 2023.4.11 #114918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pylitterbot to 2023.4.11 #114918
Conversation
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @natekspencer 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm the CI is failing, it seems like the updated library isn't fully compatible with our code/tests?
Can you take a look?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I forgot to push my last commit before opening the PR and passing out 🤦♂️. This should be good now. The new errors in CI appear unrelated to these changes. |
Ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @natekspencer 👍🏻
Breaking change
Proposed change
Fixes an issue where cat detected status is missed on Litter-Robot 4
natekspencer/pylitterbot@v2023.4.9...v2023.4.11
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: