Alexa to not use customize for entity config #11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
force-pushed
the
not-use-customize-config-alexa
branch
from
0f3bba6 to
04c7c91
Compare
bbangert
reviewed
Jan 5, 2018
| should_expose=alexa_conf[CONF_FILTER], | ||
| entity_config=alexa_conf.get(CONF_ENTITY_CONFIG), | ||
| ) | ||
| kwargs['gass_should_expose'] = gactions_conf[CONF_FILTER] |
There was a problem hiding this comment.
gass? Should the abbreviation be changed to match google actions? Maybe gact?
houndci-bot
reviewed
Jan 5, 2018
| should_expose=self._gass_should_expose, | ||
| if self._gactions_config is None: | ||
| self._gactions_config = ga_sh.Config( | ||
| should_expose=lambda e: self._gactions_should_expose(e.entity_id), |
bbangert
approved these changes
Jan 5, 2018
3 tasks
This was referenced Jan 10, 2018
Merged
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Components should never rely on config stored inside customize. This fixes this for the Alexa integration.
Related issue (if applicable): #10732
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Breaking change
Customizations for how entities are exposed to Alexa are no longer set via
customize. Instead they are set via the configuration of the cloud component:Example entry for
configuration.yaml(if applicable):cloud:Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass