Enable Ruff RET504 - #114528
Merged
Merged
Conversation
autinerd
requested review from
a team,
Danielhiversen,
Kane610,
Quentame,
StevenLooman,
TheJulianJES,
allenporter,
andrey-git,
bdraco,
bieniu,
chemelli74,
epenet,
fabaff,
gjohansson-ST,
hunterjm,
jpbede,
mib1185,
rytilahti,
starkillerOG,
syssi,
thecode and
uvjustin
as code owners
March 31, 2024 17:06
autinerd
requested review from
a team,
Jc2k,
OttoWinter,
bramkragten,
ctalkington,
davet2001,
dgomes,
elupus,
jesserockz,
ochlocracy,
synesthesiam and
teharris1
as code owners
March 31, 2024 17:06
autinerd
commented
Mar 31, 2024
chemelli74
reviewed
Apr 1, 2024
Member
|
Please solve the merge conflict. |
MartinHjelmare
marked this pull request as draft
April 4, 2024 10:29
autinerd
marked this pull request as ready for review
April 4, 2024 16:04
MartinHjelmare
requested changes
Apr 4, 2024
MartinHjelmare
left a comment
Member
There was a problem hiding this comment.
Ruff is failing for Sonos.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
autinerd
marked this pull request as ready for review
April 5, 2024 03:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This enables the Ruff RET504 rule: Unnecessary assignment before
returnstatementThis rule merges a assignment with an immediately following return together.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: