Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid tracking import executor jobs #114453

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Avoid tracking import executor jobs #114453

merged 1 commit into from
Mar 29, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 29, 2024

Proposed change

If an import was running in a background task, it would delay startup. There is no reason to track these jobs as they are always awaited and we do need to support fire and forget (ie non-awaited) import executor jobs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

There is no reason to track these jobs as they are always awaited
and we do not want to support fire and forget import executor jobs
@bdraco bdraco added this to the 2024.4.0 milestone Mar 29, 2024
@bdraco bdraco requested a review from a team as a code owner March 29, 2024 18:35
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Mar 29, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 969b027 into dev Mar 29, 2024
35 checks passed
@frenck frenck deleted the no_track_import_exec branch March 29, 2024 21:18
frenck pushed a commit that referenced this pull request Mar 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants