-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure coverage entries are sorted #114424
Conversation
Linked to #113914 |
Looks good to me. I don't see any reasons not to sort and just checked that it runs on pre-commit too which will reduce annoyance to developers. Thanks @epenet! Aside: beyond this making things even more 'neat and tidy', does having the list sorted enable something that was not possible before? |
It's just to be more "neat and tidy". Your comment made me realise that we could autofix so I implemented it that way instead in 3a880fa |
Ah ok, I see now. In that case maybe the prefix should have a comment pointing to where the autogenerated prefix/suffixes are coming from. |
I've added the comment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Merging dev to check again before merge. |
Thanks all 👍 |
Proposed change
Sample:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: