Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hassfest service icons check for custom integrations #114389

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 28, 2024

Proposed change

SSIA, hassfest is currently broken. We have enabled enforment of having service icons in the icons.json file for each service listed in the service descriptions. However, we can't enforce that for custom integration.

Right now, hassfest break everywhere in the custom integration space.

CleanShot 2024-03-28 at 15 43 13@2x

ref: https://github.com/frenck/spook/actions/runs/8468749058/job/23202486623

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner March 28, 2024 14:43
@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Mar 28, 2024
@frenck frenck added this to the 2024.4.0 milestone Mar 28, 2024
@frenck frenck merged commit 192fad0 into dev Mar 28, 2024
31 checks passed
@frenck frenck deleted the frenck-2024-0275 branch March 28, 2024 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants