Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bump_version.py to append also the time to nightlies and add possibility to set manual a nightly version #114300

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

edenhaus
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Mar 27, 2024
@edenhaus edenhaus marked this pull request as ready for review March 27, 2024 12:22
@edenhaus edenhaus requested a review from frenck March 27, 2024 12:23
@frenck frenck marked this pull request as draft March 27, 2024 12:47
@edenhaus edenhaus changed the title Add support for nightlies_datetime Update bump_version.py to append also the time to nightlies and add possibility to set manual a nightly version Mar 27, 2024
@edenhaus edenhaus force-pushed the edenhaus-nightlies-datetime branch from 3e36a18 to 8bea5cb Compare March 27, 2024 13:00
@edenhaus edenhaus marked this pull request as ready for review March 27, 2024 13:03
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @edenhaus! This is a very nice improvement 🎉

../Frenck

@edenhaus edenhaus merged commit aaecbbd into dev Mar 27, 2024
29 of 30 checks passed
@edenhaus edenhaus deleted the edenhaus-nightlies-datetime branch March 27, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants