Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review AndroidTV decorator exception management #114133

Merged
merged 6 commits into from
May 6, 2024

Conversation

ollo69
Copy link
Contributor

@ollo69 ollo69 commented Mar 24, 2024

Proposed change

This PR is to fix issue in AndroidTV test in PR #113957.
Because class entity at line 952 catch any Exception on update and stop actions, the entity status is never set to unavailable and the exception is not raised as result of update.
Not sure if this is the right way, I review the decorator to manage in the same way any kind of exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @JeffLIrion, mind taking a look at this pull request as it has been labeled with an integration (androidtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@ollo69 ollo69 mentioned this pull request Mar 24, 2024
20 tasks
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 25, 2024
@home-assistant
Copy link

home-assistant bot commented Apr 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 7, 2024 21:11
@ollo69 ollo69 force-pushed the androidtv-review-decorator branch from fb5c941 to 77dffd4 Compare April 12, 2024 21:22
@ollo69 ollo69 marked this pull request as ready for review April 12, 2024 22:11
@home-assistant home-assistant bot requested a review from davet2001 April 12, 2024 22:11
@home-assistant home-assistant bot marked this pull request as draft April 13, 2024 06:43
@ollo69 ollo69 marked this pull request as ready for review April 13, 2024 09:04
@home-assistant home-assistant bot requested a review from davet2001 April 13, 2024 09:04
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the edits.

Thanks @ollo69!

@ollo69 ollo69 mentioned this pull request Apr 22, 2024
20 tasks
@ollo69
Copy link
Contributor Author

ollo69 commented May 6, 2024

Any chance for this PR to be merged? Looks like it was forgotten...

# An unforeseen exception occurred. Close the ADB connection so that
# it doesn't happen over and over again, then raise the exception.
# it doesn't happen over and over again.
_LOGGER.error(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to log over and over?

https://developers.home-assistant.io/docs/integration_quality_scale_index?_highlight=quality#silver-

Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a check if available before logging, this should avoid to repeat error log.

@ollo69 ollo69 force-pushed the androidtv-review-decorator branch from 2f4a256 to 62d6004 Compare May 6, 2024 15:24
@ollo69 ollo69 requested a review from bdraco May 6, 2024 16:16
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ollo69

@bdraco bdraco merged commit 5db8082 into home-assistant:dev May 6, 2024
24 checks passed
@ollo69 ollo69 deleted the androidtv-review-decorator branch May 7, 2024 07:46
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed has-tests integration: androidtv Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants