Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better testing to vacuum platform #112523

Merged
merged 13 commits into from
May 8, 2024

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Mar 6, 2024

Breaking change

Proposed change

In conversations here: #112431 We realized that vacuum was not really being independently tested. This is my attempt at getting coverage up a bit. I copied based off of what the weather platform does. Open to all suggestions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 6, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (vacuum) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vacuum can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vacuum Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Mar 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 6, 2024 21:17
@Lash-L Lash-L marked this pull request as ready for review March 6, 2024 21:33
@home-assistant home-assistant bot requested a review from gjohansson-ST March 6, 2024 21:33
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2024
@home-assistant home-assistant bot marked this pull request as draft March 21, 2024 13:15
@Lash-L Lash-L marked this pull request as ready for review March 31, 2024 00:59
@home-assistant home-assistant bot requested a review from MartinHjelmare March 31, 2024 00:59
@Lash-L
Copy link
Contributor Author

Lash-L commented Mar 31, 2024

Marking as draft - will need to look at what is causing tests to fail now after merging dev.

@Lash-L Lash-L marked this pull request as draft March 31, 2024 01:19
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gjohansson-ST gjohansson-ST removed the smash Indicator this PR is close to finish for merging or closing label Apr 6, 2024
@Lash-L Lash-L marked this pull request as ready for review April 10, 2024 20:58
@home-assistant home-assistant bot marked this pull request as draft April 10, 2024 21:17
@Lash-L Lash-L marked this pull request as ready for review April 10, 2024 21:50
@home-assistant home-assistant bot requested a review from MartinHjelmare April 10, 2024 21:50
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit a77add1 into home-assistant:dev May 8, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants