-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom integration block list #112481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-03-06 00:49:59.608 WARNING (SyncWorker_15) [homeassistant.loader] We found a custom integration start_time which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-03-06 00:49:59.608 ERROR (SyncWorker_15) [homeassistant.loader] Version 1.1.6 of custom integration 'start_time' breaks Home Assistant and was blocked from loading, please create a bug report at https://github.com/AlexxIT/StartTime/issues
👍
Nice!
Should we provide a way to overwrite this? Especially if It might also make testing blocked integrations itself to provide a fix more difficult without it. -- |
@cdce8p there are a thousand ways to overcome the block list, users can manually change the version in the manifest, rename the integration, make a custom integration which clears the block list etc. etc., I don't think we also need to provide some official way. |
At least changing the version won't work if |
* Add custom integration block list * Fix typo * Add version condition * Add block reason, simplify blocked versions, add tests * Change logic for OK versions * Add link to custom integration's issue tracker * Add missing file --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Proposed change
Add custom integration block list
The block list is a dictionary where the key is the integration domain and the values have a reason why the integration is blocked, as well as the lowest version which is not blocked.
Background in #112464
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: