Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cryptography OpenSSL backend #111840

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Import cryptography OpenSSL backend #111840

merged 3 commits into from
Feb 29, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 29, 2024

Breaking change

Proposed change

Fix for race importing openssl.

Fixes #111822

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob added this to the 2024.3.0 milestone Feb 29, 2024
@balloob balloob requested a review from a team as a code owner February 29, 2024 13:22
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Feb 29, 2024
homeassistant/bootstrap.py Outdated Show resolved Hide resolved
homeassistant/bootstrap.py Outdated Show resolved Hide resolved
@balloob balloob merged commit 9512fb4 into dev Feb 29, 2024
4 checks passed
@balloob balloob deleted the cryptography branch February 29, 2024 15:28
balloob added a commit that referenced this pull request Feb 29, 2024
* Import cryptography OpenSSL backend

* No need to impor top-level. Included.

* Update homeassistant/bootstrap.py
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@bdraco bdraco added the import-deadlock import is not thread-safe in python3 https://github.com/python/cpython/issues/83065 label Apr 10, 2024
@bdraco
Copy link
Member

bdraco commented Apr 10, 2024

cpython issue is python/cpython#83065

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed core import-deadlock import is not thread-safe in python3 https://github.com/python/cpython/issues/83065 small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud throws import error with deadlock detected
2 participants