Bump bring-api to 0.5.4

[tr4nt0r]

Proposed change

• Diff: miaucl/bring-api@0.4.1...0.5.4
• Changelog: https://github.com/miaucl/bring-api/blob/0.5.4/CHANGELOG.md

Version 0.5.3 adds a new method that allows it to interact with the Bring API in the same way as the mobile apps and therefore it is now possible to use the uuid of items as unique identifiers (API Endpoints used by the webApp did not expose the item uuid). This allows it do add multiple items with the same name but different descriptions (specifications), an issue that a user tried to fix in this PR:

• Fix TodoItem uid to include the specification attribute #110226

Additionally the bring-api is now packaged with translation tables. The translation tables that are used by the webApp and were downloaded in the bring-api library before, but are outdated and differ slightly from the translation tables used in the mobile apps.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @miaucl, mind taking a look at this pull request as it has been labeled with an integration (bring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bring can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign bring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[Jhonattan-Souza]

Hi @tr4nt0r , will this solve the issue that my items inside home assistant shows a german name for items, and inside my app is my mother language pt-br ?

[miaucl]

Hi @tr4nt0r , will this solve the issue that my items inside home assistant shows a german name for items, and inside my app is my mother language pt-br ?

Have a look here: home-assistant/home-assistant.io#31655

[edenhaus]

Please fix the mypy issues

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[tr4nt0r]

Please fix the mypy issues

will do, already on it 👍🏽

[edenhaus]

Additionally the bring-api is now packaged with translation tables. The translation tables that are used by the webApp and were downloaded in the bring-api library before, are outdated and differ slightly from the translation tables used in the mobile apps.

Is this a breaking change for the users?

[edenhaus]

Your library is doing IO inside an async function, which will block the event loop.
Please run IO code in the executor and not in the event loop.

Code: miaucl/bring-api@0.4.1...0.5.3#diff-7e622e3310

[tr4nt0r]

Additionally the bring-api is now packaged with translation tables. The translation tables that are used by the webApp and were downloaded in the bring-api library before, are outdated and differ slightly from the translation tables used in the mobile apps.

Is this a breaking change for the users?

This is a follow-up to this issue:
#110571

But as #111149 hasn't been shipped to the user either, i would definitely say no.

[miaucl]

Your library is doing IO inside an async function, which will block the event loop. Please run IO code in the executor and not in the event loop.

Code: miaucl/bring-api@0.4.1...0.5.3#diff-7e622e3310

@edenhaus Please explain, what do you mean with IO? Api exchange is performed using aiohttp and should be non-blocking.

[tr4nt0r]

Your library is doing IO inside an async function, which will block the event loop. Please run IO code in the executor and not in the event loop.

Code: miaucl/bring-api@0.4.1...0.5.3#diff-7e622e3310

@edenhaus Sorry, I'm pretty new to python development. I rewrote the IO part to be executed with run_in_executor. Hope that is what you meant:
miaucl/bring-api@main...run_in_executor

[edenhaus]

File operations are also blocking and the link points to a location, where the localization file is open and read.

@tr4nt0r No problem :) I'm here to review and we can solve the issues together :)
Everyone is new to something :)

[tr4nt0r]

File operations are also blocking and the link points to a location, where the localization file is open and read.

@tr4nt0r No problem :) I'm here to review and we can solve the issues together :) Everyone is new to something :)

Ooooh, the file handler hast to be closed 🤦‍♂️

[edenhaus]

miaucl/bring-api@main...run_in_executor

The changes looks good. Please bump the api to a version, where the fix included. Afterwards please click "ready to review"

[tr4nt0r]

File operations are also blocking and the link points to a location, where the localization file is open and read.
@tr4nt0r No problem :) I'm here to review and we can solve the issues together :) Everyone is new to something :)

Ooooh, the file handler hast to be closed 🤦‍♂️

no, sorry, it doesn't have to, the with-statement does it already :D

[edenhaus]

Thanks @tr4nt0r 👍