Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read min/max number of showers from state for DomesticHotWaterProduction in Overkiz integration #111535

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

yanuino
Copy link
Contributor

@yanuino yanuino commented Feb 26, 2024

Proposed change

Use minimum and maximum number of showers available as state in water heating system to initialize min/max value of the entity number that control the expected number of shower.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, @Tronix117, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Tronix117 Tronix117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty generic to do it this way. Except the nested if, sounds good to me

homeassistant/components/overkiz/number.py Outdated Show resolved Hide resolved
Copy link
Contributor

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! This was a change that was long due :).

homeassistant/components/overkiz/number.py Outdated Show resolved Hide resolved
homeassistant/components/overkiz/number.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 26, 2024 22:10
@yanuino
Copy link
Contributor Author

yanuino commented Feb 27, 2024

I've taken your feedback into account and rewrite it using __init__ and setting self._attr_native_max_value and self._attr_native_min_value instead of inherited property. I'm open to all your comments you may have.

@iMicknl iMicknl marked this pull request as ready for review February 27, 2024 14:34
@iMicknl iMicknl merged commit e886bc8 into home-assistant:dev Feb 28, 2024
23 checks passed
@iMicknl iMicknl added this to the 2024.3.0 milestone Feb 28, 2024
balloob pushed a commit that referenced this pull request Feb 29, 2024
…ion in Overkiz integration (#111535)

* Read min/max number of showers from state

* Rewrite code for Read min/max number of showers from state

* Set _attr_ instead of inherited value
@yanuino yanuino deleted the overkiz-issue92368 branch February 29, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants