-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read min/max number of showers from state for DomesticHotWaterProduction in Overkiz integration #111535
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, @Tronix117, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty generic to do it this way. Except the nested if
, sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! This was a change that was long due :).
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I've taken your feedback into account and rewrite it using |
…ion in Overkiz integration (#111535) * Read min/max number of showers from state * Rewrite code for Read min/max number of showers from state * Set _attr_ instead of inherited value
Proposed change
Use minimum and maximum number of showers available as state in water heating system to initialize min/max value of the entity number that control the expected number of shower.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: