Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comelit humidifier/dehumidifier #111203

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Add Comelit humidifier/dehumidifier #111203

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6db7590
Add Comelit humidifier/dehumidifier
chemelli74 Feb 23, 2024
b628298
optimize turn_on
chemelli74 Feb 25, 2024
a859db6
fix entity naming
chemelli74 Feb 28, 2024
a728b7e
raise ServiceValidationError
chemelli74 Feb 28, 2024
280a4d6
apply review comment
chemelli74 Feb 28, 2024
534d4a9
apply review comments
chemelli74 Feb 28, 2024
f6efdc3
rename HumidifierComelitAction
chemelli74 Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rename HumidifierComelitAction
  • Loading branch information
@chemelli74
chemelli74 committed Feb 28, 2024
commit f6efdc37df2699a90034bdd4a9689db0609f79ca
26 changes: 13 additions & 13 deletions homeassistant/components/comelit/humidifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class HumidifierComelitMode(StrEnum):
UPPER = "U"


class HumidifierComelitAction(StrEnum):
"""Serial Bridge humidifier actions."""
class HumidifierComelitCommand(StrEnum):
"""Serial Bridge humidifier commands."""

OFF = "off"
ON = "on"
Expand All @@ -46,9 +46,9 @@ class HumidifierComelitAction(StrEnum):
UPPER = "upper"


MODE_TO_ACTION: dict[str, HumidifierComelitAction] = {
MODE_AUTO: HumidifierComelitAction.AUTO,
MODE_NORMAL: HumidifierComelitAction.MANUAL,
MODE_TO_ACTION: dict[str, HumidifierComelitCommand] = {
MODE_AUTO: HumidifierComelitCommand.AUTO,
MODE_NORMAL: HumidifierComelitCommand.MANUAL,
}


Expand All @@ -70,7 +70,7 @@ async def async_setup_entry(
config_entry.entry_id,
active_mode=HumidifierComelitMode.LOWER,
active_action=HumidifierAction.DRYING,
set_action=HumidifierComelitAction.LOWER,
set_command=HumidifierComelitCommand.LOWER,
device_class=HumidifierDeviceClass.DEHUMIDIFIER,
)
)
Expand All @@ -81,7 +81,7 @@ async def async_setup_entry(
config_entry.entry_id,
active_mode=HumidifierComelitMode.UPPER,
active_action=HumidifierAction.HUMIDIFYING,
set_action=HumidifierComelitAction.UPPER,
set_command=HumidifierComelitCommand.UPPER,
device_class=HumidifierDeviceClass.HUMIDIFIER,
),
)
Expand All @@ -105,7 +105,7 @@ def __init__(
config_entry_entry_id: str,
active_mode: HumidifierComelitMode,
active_action: HumidifierAction,
set_action: HumidifierComelitAction,
set_command: HumidifierComelitCommand,
device_class: HumidifierDeviceClass,
) -> None:
"""Init light entity."""
Expand All @@ -120,7 +120,7 @@ def __init__(
self._attr_translation_key = device_class.value
self._active_mode = active_mode
self._active_action = active_action
self._set_action = set_action
self._set_command = set_command

@property
def _humidifier(self) -> list[Any]:
Expand Down Expand Up @@ -187,10 +187,10 @@ async def async_set_humidity(self, humidity: int) -> None:
)

await self.coordinator.api.set_humidity_status(
self._device.index, HumidifierComelitAction.MANUAL
self._device.index, HumidifierComelitCommand.MANUAL
)
await self.coordinator.api.set_humidity_status(
self._device.index, HumidifierComelitAction.SET, humidity
self._device.index, HumidifierComelitCommand.SET, humidity
)

async def async_set_mode(self, mode: str) -> None:
Expand All @@ -202,11 +202,11 @@ async def async_set_mode(self, mode: str) -> None:
async def async_turn_on(self, **kwargs: Any) -> None:
"""Turn on."""
await self.coordinator.api.set_humidity_status(
self._device.index, self._set_action
self._device.index, self._set_command
)

async def async_turn_off(self, **kwargs: Any) -> None:
"""Turn off."""
await self.coordinator.api.set_humidity_status(
self._device.index, HumidifierComelitAction.OFF
self._device.index, HumidifierComelitCommand.OFF
)
Loading