Skip to content

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Feb 22, 2024

Breaking change

Proposed change

This PR:

  • bumps brother library to version 4.0.0
  • adds device MAC address to DeviceInfo connections
  • simplifies the creation of DeviceInfo
  • slightly changes the diagnostics structure because of moving firmware, model, serial from the data to the properties of the Brother class

Changelog: bieniu/brother@3.0.0...4.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bieniu bieniu force-pushed the brother-bump-lib-mac branch from 1fd132e to b5834de Compare February 22, 2024 20:13
@thecode thecode merged commit bccd9bd into home-assistant:dev Feb 22, 2024
@bieniu bieniu deleted the brother-bump-lib-mac branch February 22, 2024 21:42
@bieniu
Copy link
Member Author

bieniu commented Feb 22, 2024

Thanks @thecode

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brother printer device not matching with nmap device tracker entity
2 participants