Add light platform to microBees and change docstring in sensor #111093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @microBeesTech, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jpbede
requested changes
Feb 21, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This was referenced Feb 22, 2024
jpbede
requested changes
Feb 22, 2024
jpbede
reviewed
Feb 23, 2024
jpbede
approved these changes
Feb 23, 2024
| sendCommand = await self.coordinator.microbees.sendCommand( | ||
| self.actuator_id, 1, color=self._attr_rgbw_color | ||
| ) | ||
| if sendCommand: |
There was a problem hiding this comment.
Invert this check and raise if true. Then we can outdent below.
TheNoim
pushed a commit
to TheNoim/homeassistant-core
that referenced
this pull request
Feb 25, 2024
…assistant#111093) * Add light platform to microBees and change docstring in sensor * update .coveragerc * fixes review * fixes review * fixes async_add_entities
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
add light platform
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: