Skip to content

Conversation

edenhaus
Copy link
Member

@edenhaus edenhaus commented Feb 19, 2024

Breaking change

Deprecate the mailbox integration platform and the asterisk integrations, as they only implement the mailbox platform.

We deprecate the mailbox integration because the mailbox platform is used only by the asterisk integrations, where asterix_cdr has 0 active installations and asterisk_mbox only 25. By removing the mailbox platform we can also remove the custom mailbox panel from the frontend.

Proposed change

We deprecate the mailbox integration because the mailbox platform is used only by the asterisk integrations, where asterix_cdr has 0 active installations and asterisk_mbox only 25. By removing the mailbox platform we can also remove the custom mailbox panel from the frontend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

I think we should add some context in the PR description why we remove the mailbox integration.

@edenhaus edenhaus marked this pull request as ready for review February 26, 2024 18:25
@edenhaus edenhaus requested a review from emontnemery February 26, 2024 18:25
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 27, 2024 07:28
@edenhaus edenhaus marked this pull request as ready for review February 27, 2024 09:02
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edenhaus
Copy link
Member Author

CI / Run tests Python 3.11 (7) (pull_request) :
FAILED tests/components/switcher_kis/test_init.py::test_update_fail - AssertionError: assert 'unavailable' != 'unavailable' is unrelated

@edenhaus edenhaus merged commit d7fb949 into dev Feb 27, 2024
@edenhaus edenhaus deleted the edenhaus-mailbox-deprecation branch February 27, 2024 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants