-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiohttp to 3.9.4 #110730
Merged
Merged
Bump aiohttp to 3.9.4 #110730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is rc0 for now but will be updated when the full release it out
The websocket test failures are fine, they need to change the code. The file upload ones need to be investigated |
I did manually verify file upload works so it might be that file uploading now writes in the executor instead of doing blocking I/O in the event loop that cause the test to fail 🤞 |
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
bdraco
commented
Apr 11, 2024
reran because of flakey influxdb test. I've attempted to fix it in #115442 |
thecode
approved these changes
Apr 11, 2024
Thanks |
frenck
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Bump aiohttp to 3.9.4 This is rc0 for now but will be updated when the full release it out * cleanup cruft * regen * fix tests (these changes are fine) * chunk size is too small to read since boundry is now enforced * chunk size is too small to read since boundry is now enforced
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
https://github.com/aio-libs/aiohttp/releases/tag/v3.9.4
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: