-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruff to 0.2.1 #109796
Update ruff to 0.2.1 #109796
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @sdb9696, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -96,7 +96,7 @@ async def _async_update_data(self): | |||
if history_task: | |||
data[device.id].history = history_task.result() | |||
except ExceptionGroup as eg: | |||
raise eg.exceptions[0] | |||
raise eg.exceptions[0] # noqa: B904 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in the other PR you had fixed it and put a raise from
but in this one you’re suppressing B904. Was there something wrong with the other way or some other reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The except
here catches an ExceptionGroup
, not just a single exception. Adding from eg
here would add unhandled errors in a TaskGroup (1 sub-exception)'
to the end of the except message. Not sure that makes sense. I'm open to suggestions though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks that makes sense and I don’t have a better suggestion atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md#021
https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md#020
For the
0.2.0
update some rules have been remapped:Furthermore, I've disabled
B904
for thetests
subdirectory as I don't think it makes much sense there to enforce it.Lastly, most config sections have been moved / renamed. They now use the
[ruff.lint...]
prefix instead of just[ruff....]
.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: