-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce MELCloud poll frequency to avoid throttling #109750
Reduce MELCloud poll frequency to avoid throttling #109750
Conversation
Last ditch effort to load shed at the expense of user experience to keep the lights on. Let's keep out fingers crossed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vilppuvuorinen 👍
../Frenck
If reducing polling requests fixes the issue, how do you reduce the polling requests? |
I am impacted by this Mitsubishi change. I then tried to update the refresh interval, but everything is still unavailable in HA
Dont you think it might be worth to rate limit this call separately ? |
Might it be worth making the polling intervals user-settable, with the proposed changes as defaults instead? Include a warning in the docs about setting them too high. This is bound to happen again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just increases the interval between queries to the Melcloud app interface, and should not break anything though as noted in the comment it will reduce responsiveness and stats granularity. However, making the times user-configurable would be preferable longer term (until Mitsubishi change something more substantial) as this is a change that is likely to have to happen again.
You can already do that, please checkout the docs for the homeassistant.update_entity service |
Yes, you can if you are confident enough to delve into the YAML, but a lot of people using this now are not editing things that way. Maybe I should be more specific, but I was trying to keep it short. There is no GUI option to change this nor is it highlighted in anyway in the UI. |
That's incorrect. That doesn't work via YAML, that works via an automation. You can disable polling on an integration to then add your own polling rate via the integration. |
Fine but that's still non-trivial and beyond a lot of people. You only have to look at the comments on the issues related to this to see that. Having a simpler way to configure the polling interval would let a lot of people workaround it without needing detailed instructions or a change to the integration itself. |
We're not going to do nor allow that. This approach is already available, documented and applicable to almost every integration. This approach gives the user way more freedom to poll whenever they want. |
We don't allow for configuring polling intervals in the UI. I won't go into the details on all the reasons why, as that will be an extensive list. But there are very good reasons for that. Yes, we do hear the requests for it; no, it has been decided it will not be allowed. ../Frenck |
Hi Frenck, Do you propose that we roll back to 11.4 or is a solution in progress? |
This is an server side issue |
I can see that vilppuvuorinen is no longer codeowner ? |
@coolkeve Well, that happens and is fine. The upstream repository he has archived in 2020 already. Anybody can contribute code 🤷 But let's not discuss stuff like that on a PR, as those should be focussed on the review of the change. 😄 ../Frenck |
Last ditch effort to load shed at the expense of user experience to keep the lights on. Let's keep out fingers crossed.
Breaking change
Proposed change
Reduce poll rates to avoid throttling. The user effect takes a hit here, but I don't want to go back to using the TV remote thingy😢
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: