Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-bring-api to 3.0.0 #109720

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Feb 5, 2024

Proposed change

In 3.0.0 of the bring lib, every function is now available as sync and async. As home assistant prefers async, we convert it now to async. This also solves: #109655 and #109257

Diff: https://github.com/eliasball/python-bring-api/compare/7817147..8043562
Notes: https://github.com/eliasball/python-bring-api?tab=readme-ov-file#300

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 5, 2024

Hey there @tr4nt0r, mind taking a look at this pull request as it has been labeled with an integration (bring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bring can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@miaucl miaucl mentioned this pull request Feb 5, 2024
20 tasks
@joostlek joostlek changed the title Use async functions for bring Bump python-bring-api to 3.0.0 Feb 5, 2024
@joostlek joostlek added this to the 2024.2.0 milestone Feb 5, 2024
@frenck frenck merged commit 53d46ac into home-assistant:dev Feb 5, 2024
52 of 53 checks passed
frenck pushed a commit that referenced this pull request Feb 5, 2024
@miaucl miaucl deleted the bring_async branch February 5, 2024 20:10
@@ -25,7 +25,7 @@ def mock_setup_entry() -> Generator[Mock, None, None]:


@pytest.fixture
def mock_bring_client() -> Generator[Mock, None, None]:
def mock_bring_client() -> Generator[AsyncMock, None, None]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bring client class will be mocked as a MagicMock.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring integration, code page wrong
4 participants