-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify climate turn_on/off backwards compatibility check #109195
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjohansson-ST 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gjohansson-ST 👍
if self._enable_turn_on_off_backwards_compatibility is False: | ||
# Return if integration has migrated already | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test for this, but let's do it in a follow-up PR.
Proposed change
Modified the behavior of the backwards compatibility check for
climate
TURN_ON
andTURN_OFF
feature flags_enable_turn_on_off_backwards_compatibility
to Falseturn_off
method is set by integration it will add the feature flagTURN_OFF
turn_on
method is set by integration it will add the feature flagTURN_ON
off
then both feature flags will be addedInitial implementation in #101673
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: