Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify climate turn_on/off backwards compatibility check #109195

Merged
merged 14 commits into from
Jan 31, 2024

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Modified the behavior of the backwards compatibility check for climate TURN_ON and TURN_OFF feature flags

  • Integrations can say it has already implemented accordingly by setting _enable_turn_on_off_backwards_compatibility to False
  • If turn_off method is set by integration it will add the feature flag TURN_OFF
  • If turn_on method is set by integration it will add the feature flag TURN_ON
  • If hvac modes >= 2 and one is off then both feature flags will be added
  • Otherwise feature flags are not added and methods can not be used.

Initial implementation in #101673

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/climate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/climate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/climate/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjohansson-ST 👍

@emontnemery emontnemery self-requested a review January 31, 2024 12:53
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 31, 2024
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

@raman325 raman325 marked this pull request as ready for review January 31, 2024 14:34
@raman325 raman325 requested a review from a team as a code owner January 31, 2024 14:34
@raman325 raman325 requested review from frenck, elupus and a team as code owners January 31, 2024 14:34
Comment on lines +365 to +367
if self._enable_turn_on_off_backwards_compatibility is False:
# Return if integration has migrated already
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for this, but let's do it in a follow-up PR.

@emontnemery emontnemery merged commit ddb56fe into dev Jan 31, 2024
53 checks passed
@emontnemery emontnemery deleted the climate-fix-on_off-deprecation branch January 31, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants