-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing ZHA metering device types #109126
Merged
dmulcahey
merged 5 commits into
home-assistant:dev
from
jeverley:zha_metering_device_types
Jan 30, 2024
Merged
Add missing ZHA metering device types #109126
dmulcahey
merged 5 commits into
home-assistant:dev
from
jeverley:zha_metering_device_types
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jeverley
changed the title
Update smartenergy.py metering_device_type enums
ZHA Metering add missing metering_device_type enums
Jan 30, 2024
jeverley
force-pushed
the
zha_metering_device_types
branch
from
January 30, 2024 14:13
85cd17b
to
d5aef20
Compare
jeverley
requested review from
dmulcahey,
Adminiuga,
puddly and
TheJulianJES
as code owners
January 30, 2024 14:50
dmulcahey
reviewed
Jan 30, 2024
homeassistant/components/zha/core/cluster_handlers/smartenergy.py
Outdated
Show resolved
Hide resolved
Addresses home-assistant#109126 (comment) Whilst I have the code open I've also added status handlers for the non-electrical meter types.
dmulcahey
approved these changes
Jan 30, 2024
TheJulianJES
approved these changes
Jan 30, 2024
TheJulianJES
changed the title
ZHA Metering add missing metering_device_type enums
Add missing ZHA metering device types
Jan 30, 2024
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the full set of supported MeteringDeviceType values exposed by the Zigbee Metering cluster.
https://zigbeealliance.org/wp-content/uploads/2021/10/07-5123-08-Zigbee-Cluster-Library.pdf
Also implements handlers for the different device type statuses (Electrical, gas, water, heating/cooling).
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: