-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SleepIQ setting FootWarmer timer #108433
Fix SleepIQ setting FootWarmer timer #108433
Conversation
Hey there @mfugate1, @kbickar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Just a note that this will make a duplicate API call when the mode and time are set |
That's a good call out! Do you have any ideas on how we could avoid that? Maybe there is a way I can detect the call is coming from a select, or if the time is the same as the current time it could no op out? |
There isn't really any way to fix that. The user can choose to set the time first or the mode first. Since they're different entities, there's nothing requiring them to do them in any order or to do both |
If I change it to set the value of timer if off. And if it's on I will make the api call to set the the timer to the new value with the current temp. Would that be a good compromise? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to take in the dependency bump.
(Also, I saw some issues about the footwarmer, are they fixed with this PR? If so, you can add them as well)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There's a single API call that takes the temperature setting and the time so it doesn't really matter what order you set them in. If the time is set to 0 it defaults to 2 minutes |
Sorry, I am honestly new to rebasing with git. I think I did it correctly. Please let me know if I did it wrong. Thank you! |
The bug fixes for the foot warmers mentioned in the previous PR #108431 were fixed by the library bump. It was an internal bug that didn't refresh data properly. This should be the only change needed here. Once this gets checked in I am going to start a new PR that adds new features for Core Climate support for the Sleep IQ integration. |
f42efec
to
c6f8864
Compare
* Fixing foot warmer timer bug * Fixing bug where temperature wasnt assigned to number entity causing tests to fail
Proposed change
Note: This is dependent on #108431 being merged.
A small change to the number entity for the SleepIQ Bed Foot Warmer Timer.
Currently the Foot Warmer timer number entity will not update the SleepIQ API, it is just used internally by HA when using the select.
This change will allow a user to change the timer on the fly and it will update the API with their current selected mode and the new timer value.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: