Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration of unused refresh tokens #108428

Merged
merged 19 commits into from
Jan 24, 2024
Merged

Add expiration of unused refresh tokens #108428

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
90be51c
add expire_at for new and non long-lived tokens
mib1185 Jan 20, 2024
08404e5
simplifiy the scheduling
mib1185 Jan 20, 2024
9149854
use list view
mib1185 Jan 20, 2024
6e519b6
use [:] view instaed of list()
mib1185 Jan 21, 2024
61d75f1
Merge branch 'dev' into auth/add-refresh_token-expiration
bdraco Jan 21, 2024
2b6da19
Merge branch 'dev' into auth/add-refresh_token-expiration
bdraco Jan 21, 2024
aa1cbbe
lint fixes from merge conflict
bdraco Jan 21, 2024
de35bf4
async_get_refresh_tokens no longer needs to be a coro
bdraco Jan 21, 2024
3350077
move scheduler init to async_setup
mib1185 Jan 21, 2024
bf04edf
uset timestamp for expire_at
mib1185 Jan 21, 2024
2a3d64b
extend test
mib1185 Jan 22, 2024
1c4eb50
Merge branch 'dev' into auth/add-refresh_token-expiration
mib1185 Jan 22, 2024
b4bb971
fix
mib1185 Jan 22, 2024
6cbd270
Merge branch 'dev' into auth/add-refresh_token-expiration
bdraco Jan 23, 2024
0a022b3
adapt to changes
bdraco Jan 23, 2024
ad7af36
adapt to changes
bdraco Jan 23, 2024
e891f98
id check
bdraco Jan 23, 2024
1350ef3
let's do 90 days for all
mib1185 Jan 24, 2024
ba0940a
test adding expired_at if not existing
mib1185 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
id check
  • Loading branch information
@bdraco
bdraco committed Jan 23, 2024
commit e891f984f43ce6b76f33d89bc4e8c86ce68f4b17
2 changes: 1 addition & 1 deletion homeassistant/auth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ async def async_create_refresh_token(
else:
token_type = models.TOKEN_TYPE_NORMAL

if token_type == models.TOKEN_TYPE_NORMAL:
if token_type is models.TOKEN_TYPE_NORMAL:
expire_at = time.time() + REFRESH_TOKEN_EXPIRATION
else:
expire_at = None
Expand Down